Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/transitgateway: Fix resource Read pagination regression causing NotFound errors #38011

Merged

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 17, 2024

Description

Fixes a regression caused by use of if pages.HasMorePages() instead of for pages.HasMorePages() leading to Transit Gateway services paginators terminating early.

Relations

Closes #38009.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccTransitGateway_serial/RouteTablePropagation/basic' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/RouteTablePropagation/basic -timeout 360m
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/Gateway_DefaultRouteTablePropagation
=== PAUSE TestAccTransitGateway_serial/Gateway_DefaultRouteTablePropagation
=== RUN   TestAccTransitGateway_serial/VpcAttachment_TransitGatewayDefaultRouteTablePropagation
=== PAUSE TestAccTransitGateway_serial/VpcAttachment_TransitGatewayDefaultRouteTablePropagation
=== RUN   TestAccTransitGateway_serial/RouteTablePropagation_basic
=== PAUSE TestAccTransitGateway_serial/RouteTablePropagation_basic
=== RUN   TestAccTransitGateway_serial/RouteTablePropagation_disappears
=== PAUSE TestAccTransitGateway_serial/RouteTablePropagation_disappears
=== RUN   TestAccTransitGateway_serial/Connect_TransitGatewayDefaultRouteTablePropagation
=== PAUSE TestAccTransitGateway_serial/Connect_TransitGatewayDefaultRouteTablePropagation
=== CONT  TestAccTransitGateway_serial/Gateway_DefaultRouteTablePropagation
=== CONT  TestAccTransitGateway_serial/RouteTablePropagation_disappears
=== CONT  TestAccTransitGateway_serial/RouteTablePropagation_basic
=== CONT  TestAccTransitGateway_serial/Connect_TransitGatewayDefaultRouteTablePropagation
=== CONT  TestAccTransitGateway_serial/VpcAttachment_TransitGatewayDefaultRouteTablePropagation
--- PASS: TestAccTransitGateway_serial (0.00s)
    --- PASS: TestAccTransitGateway_serial/Gateway_DefaultRouteTablePropagation (285.99s)
    --- PASS: TestAccTransitGateway_serial/RouteTablePropagation_disappears (306.69s)
    --- PASS: TestAccTransitGateway_serial/VpcAttachment_TransitGatewayDefaultRouteTablePropagation (334.06s)
    --- PASS: TestAccTransitGateway_serial/RouteTablePropagation_basic (339.25s)
    --- PASS: TestAccTransitGateway_serial/Connect_TransitGatewayDefaultRouteTablePropagation (456.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	460.963s

@ewbankkit ewbankkit requested a review from a team as a code owner June 17, 2024 13:17
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. linter Pertains to changes to or issues with the various linters. labels Jun 17, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 17, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit merged commit b41962f into main Jun 17, 2024
55 checks passed
@ewbankkit ewbankkit deleted the b-aws_ec2_transit_gateway_route_table_propagation-pagination branch June 17, 2024 14:09
@github-actions github-actions bot added this to the v5.55.0 milestone Jun 17, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Jun 17, 2024
Copy link

This functionality has been released in v5.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 20, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linter Pertains to changes to or issues with the various linters. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
2 participants